Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add default cloud functionality #1326

Closed
wants to merge 2 commits into from

Conversation

kian99
Copy link
Contributor

@kian99 kian99 commented Aug 26, 2024

Description

This PR enables JIMM to use a default cloud when a user doesn't specify a cloud during model creation. The reasoning for the change is:

When running the Juju Terraform Provider’s test suite against JIMM it was found that JIMM behaves slightly differently from Juju when adding a model.
In Juju, when adding a model, if only 1 cloud is available, the user is not required to specifying a cloud and the available cloud will be used for model creation.
In JIMM, a cloud must always be specified otherwise an error is returned.

This duplicates #1325

Fixes CSS-10366

I also took the chance to move model related methods into a separate interface in jujuapi.

Engineering checklist

Check only items that apply

  • Documentation updated
  • Covered by unit tests
  • Covered by integration tests

Test instructions

Notes for code reviewers

@kian99 kian99 requested a review from a team as a code owner August 26, 2024 09:46
@kian99
Copy link
Contributor Author

kian99 commented Aug 27, 2024

Closed in favour of #1325

@kian99 kian99 closed this Aug 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants